CS Fixes #1372
Merged
CS Fixes #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Changing php-cs-fixer config filename to the default so it's detected without having to specify the config flag
Running php-cs-fixer to fix CS drift
when specifying multiple files php-cs-fixer needs to be provider rules or the config file. see PHP-CS-Fixer/PHP-CS-Fixer#4279
JimTools
force-pushed
the
bugfix/cs-drift
branch
from
2b3f908 to
8e72d15
Compare
|
@makasim I've fixed the code style checks and that's now green. But there's an issue with Symfony 6.2/6.3. I've spent some time debugging it but have not gotten anywhere yet. However, it doesn't look like the CS fixes have caused this. I've checked out |
|
@JimTools thank you |
|
@makasim you’re welcome, the static analysis changes should be good to go as well. I’ll continue looking into CI failures and fix the rest of the warnings in the test output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1336 #1369