Removing unneeded dep on psr/http-message #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @weierophinney. |
ravage84
reviewed
Feb 5, 2020
| "php": "^5.3 || ^7.0" | ||
| }, | ||
| "suggest": { | ||
| "psr/http-message": "The package containing the PSR-7 interfaces" |
There was a problem hiding this comment.
Since this package was intended as a direct utility for the PSR-7 package it makes sense to suggest it.
But in hinsight of what the package currently provides (generally usable HTTP related constants), it isn't even necessary to suggest the other package.
There was a problem hiding this comment.
I think the suggestion is still a good idea; it's not saying you MUST install them, but it IS indicating that the primary reason they exist is for that package.
weierophinney
approved these changes
Feb 5, 2020
weierophinney
added a commit
that referenced
this pull request
Feb 5, 2020
weierophinney
added a commit
that referenced
this pull request
Nov 24, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #13, we can remove this dep (and move it as a suggestion) to the PSR-7 package, since we do not use it directly.