Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: extend tools docs #170

Merged
merged 1 commit into from
Dec 21, 2024
Merged

docs: extend tools docs #170

merged 1 commit into from
Dec 21, 2024

Conversation

chr-hertel
Copy link
Member

No description provided.

method arguments and param comments in the doc block. Additionally, JSON Schema support validation rules, which are
partially support by LLMs like GPT.

To leverage this, configure the `#[ToolParameter]` attribute on the method arguments of your tool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a link to the class ToolParameter?

Offtopic, but maybe it's more fail safe to have sth like "#[Minimum]" etc as we can then validate it is only used for integers for example 🤔 to avoid god classes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a comment below the example code to link to the attribute class, good idea 👍

i do get the intention in resolving the mega attribute class, but on the other hand it would make it harder to parse that thing in ParameterAnalyzer

@chr-hertel chr-hertel merged commit f7d8aa0 into main Dec 21, 2024
7 checks passed
@chr-hertel chr-hertel deleted the docs-tools branch December 21, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants