Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHPUnit 8.1 compatibility #34

Closed
davidkmenta opened this issue Apr 5, 2019 · 2 comments
Closed

Add PHPUnit 8.1 compatibility #34

davidkmenta opened this issue Apr 5, 2019 · 2 comments
Assignees
@michalbundyra
Milestone
2.3.0

Comments

@davidkmenta
Copy link

It seems that php-mock implements some interfaces which were marked as @internal in the new version of the PHPUnit and those objects aren't backward compatible anymore 😢
@michalbundyra
Copy link
Member

@davidkmenta Thanks for reporting the issue. I'll have a look on it later on, unless you want provide a patch? 😄

@michalbundyra michalbundyra transferred this issue from php-mock/php-mock Apr 5, 2019
michalbundyra added a commit to michalbundyra/php-mock-phpunit that referenced this issue Apr 5, 2019
@michalbundyra
Added PHPUnit 8.1 support
e49762c 
Resolves php-mock#34
@michalbundyra michalbundyra mentioned this issue Apr 5, 2019
Merged
@michalbundyra michalbundyra added this to the 2.3.0 milestone Apr 5, 2019
@michalbundyra michalbundyra self-assigned this Apr 5, 2019
michalbundyra added a commit that referenced this issue Apr 6, 2019
@michalbundyra
Merge branch 'feature/phpunit-8.1-support'
d49b8c5 
Close #35
Fix #34
@michalbundyra
Copy link
Member

@davidkmenta php-mock-phpunit 2.3.0 released with support for PHPUnit 8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalbundyra michalbundyra

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
2 participants
@davidkmenta @michalbundyra