Added PHPUnit 6.5 to Travis CI config #20
Conversation
|
Look like the 6.5 is actually broken - I just coincidentally also reported #21 . |
|
@OndraM Please have a look on my changes, all now works with PHPUnit 6.5 on all PHP versions :) |
|
Ping @malkusch |
|
Thank you for your effort. But I won't go for this solution. I consider PHPUnit-6.5 did a BC breaking change. As a hot fix for the currently broken release I simply drop support for PHPUnit-6.5. |
| { | ||
| MockFunctionGenerator::removeDefaultArguments($invocation->parameters); | ||
| $r = new \ReflectionObject($invocation); |
There was a problem hiding this comment.
That's nice as a work around but not sustainable. Relying on implementation details can break at any upstream patch release. I try to get a public interface for that.
There was a problem hiding this comment.
It was the only possible solution in current situation. If the public interface change then we can improve this part.
There was a problem hiding this comment.
I know. I just wanted to give you some context why I closed this PR so that you won't get frustrated.
There was a problem hiding this comment.
It's your library, you can do whatever you want ! :)
I would consider release v2.1 with support PHPUnit 6.5+ only and everyone will be happy 😄
Of course, still there will be the same issue, and only reflection will be the way to that...
There was a problem hiding this comment.
I would consider release v2.1 with support PHPUnit 6.5+ only
Ah that's still a little fuck up. Unfortunaltey I have to make a further 2.0 release which supports 6.5 otherwise 2.0 is broken.
PR based on #19, to see if all works: PHP 7.2 and PHPUnit 6.5