Support for automatic reconnects #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #104, this PR attempts to implement automatic reconnects. The implementation has this feature disabeld by default for backwards compatibility.
To simplify the code and avoid code duplication,
writeToSocket()andreadFromSocket()have been wrapped with thewriteToSocketWithAutoReconnect()andreadFromSocketWithAutoReconnect()counterparts. We also do not use auto-reconnect logic during connection handshakes to prevent recursion issues.As of now, the PR lacks tests because it is quite difficult to have the broker disconnect the client on command. If anyone has an idea what logic could be used to force a disconnect server-side, I'd greatly appreciate it!