-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve: Setting dbType to enum is not totally correct #45 #46
Resolve: Setting dbType to enum is not totally correct #45 #46
Conversation
Is it possible to write a test for the case fixed here? |
…-correct' of github.com:php-openapi/yii2-openapi into 45-setting-dbtype-to-enum-is-not-totally-correct
Yes it is possible but I think it is not needed. Because this PR only removes unnecessary code
rest all changes are just of refactoring and not related to this PR. Also existing test covers this PR:
so I think no new tests are needed |
Thank you! |
Fixes #45