-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added locking mechanism #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/lock
branch
9 times, most recently
from
May 15, 2017 09:46
ff4a807
to
3fa0b34
Compare
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 15, 2017 11:39
3fa0b34
to
5d58464
Compare
alexander-schranz
requested changes
May 15, 2017
->end() | ||
->end() | ||
->end() | ||
->enumNode('mode')->values(['off', 'listener'])->defaultValue('off')->end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 15, 2017 14:41
5d58464
to
c7a5606
Compare
@alexander-schranz fixed |
danrot
approved these changes
May 16, 2017
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 16, 2017 10:59
c7a5606
to
68f8bc3
Compare
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 18, 2017 06:25
799da04
to
e19b915
Compare
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 18, 2017 06:37
e19b915
to
37f1ff2
Compare
wachterjohannes
force-pushed
the
feature/lock
branch
from
May 18, 2017 07:03
f4d5a16
to
5ef00c2
Compare
alexander-schranz
requested changes
May 18, 2017
composer.json
Outdated
@@ -11,9 +11,10 @@ | |||
], | |||
"require": { | |||
"php": "~5.5 || ~7.0", | |||
"php-task/php-task": "dev-develop", | |||
"php-task/php-task": "dev-feature/lock", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wachterjohannes fix
@alexander-schranz done |
alexander-schranz
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates locking mechanism from php-task/php-task#35