Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation with psr/log 2.x and 3.x #253

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

JeroenDeDauw
Copy link
Contributor

No description provided.

@@ -60,7 +60,7 @@
"monolog/monolog": ">=1.11.0",
"vimeo/psalm": "^4",
"php-http/cache-plugin": "^1.7",
"wmde/psr-log-test-doubles": "^2"
"jeroen/psr-log-test-doubles": "^2.1 || ^3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the new location where I maintain the library. Version 3 is needed to support the new psr/log versions.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022

Codecov Report

Merging #253 (c32d90b) into 4.0 (3d87c2d) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                4.0     #253      +/-   ##
============================================
- Coverage     81.53%   81.46%   -0.07%     
+ Complexity     2253     2251       -2     
============================================
  Files           203      202       -1     
  Lines          5658     5515     -143     
============================================
- Hits           4613     4493     -120     
+ Misses         1045     1022      -23     
Impacted Files Coverage Δ
lib/Tmdb/Factory/FindFactory.php 74.46% <0.00%> (-2.01%) ⬇️
...Formatter/HttpMessage/FullHttpMessageFormatter.php 91.17% <0.00%> (-0.72%) ⬇️
lib/Tmdb/Client.php 90.00% <0.00%> (-0.59%) ⬇️
.../Tmdb/Event/Listener/Psr6CachedRequestListener.php 88.88% <0.00%> (-0.31%) ⬇️
lib/Tmdb/Helper/ImageHelper.php 96.29% <0.00%> (-0.26%) ⬇️
lib/Tmdb/Repository/MovieRepository.php 98.07% <0.00%> (-0.23%) ⬇️
lib/Tmdb/Model/Person.php 87.50% <0.00%> (-0.18%) ⬇️
...b/Event/Listener/Logger/LogHttpMessageListener.php 97.50% <0.00%> (-0.12%) ⬇️
lib/Tmdb/Factory/MovieFactory.php 89.79% <0.00%> (-0.07%) ⬇️
lib/Tmdb/Api/Lists.php 100.00% <0.00%> (ø)
... and 31 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wtfzdotnet wtfzdotnet merged commit 02a21ea into php-tmdb:4.0 Apr 29, 2022
@wtfzdotnet
Copy link
Member

Thanks for the bump :-)!

@JeroenDeDauw JeroenDeDauw deleted the support-psr-log-3 branch April 29, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants