-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annoucement: php-webdriver repository organization name change #730
Comments
Would it maybe make sense to name the package |
@christian-bromann I just want to say that if you do so you will limit future languages in the namespace |
You right, I didn't know that packagist is using GitHubs namespaces.
I agree! Happy to give any kind of access to it. |
I agree that I was unclear, |
Yeah, I didn't know that packagist is using GitHub namespaces. So |
|
I don't think it really matters too much whether it's Personally my vote would be for There are some benefits to having it under the
Equally, there are benefits to a new Organisation for the project:
In terms of time I think that it actually makes a lot more sense to move at 1.8.0 rather than 2.0.0. tl;dr:
|
Makes totally sense given that the raw bindings for WebDriver in JS land is also in the WebdriverIO project. |
GitHub repostiory organization/name is not related to Packagist namespace/name. Even now it is github Having different package name on GitHub and on Packagist is relatively common - they don't need and often are not the same - for example common rule is not to include "php" in package name on Packagist, if the reason why it is used on GitHub is to differentiate if from clients for other languages, as GitHub hosts project in different languages. You don't need to do this on Packagist, because, well, Packagist contains only PHP packages :-). On the other hand, organization on GitHub is usually the same as namespace on Packagist. So I agree with @andrewnicols about naming github repository And for reasons above I preffer Both of these names also provide benefits mentioned by @andrewnicols (possibility to host related PHP projects in the future under php-webdriver org/namespace). What do you think? |
@OndraM What do you think about the timing? |
About moving the repo itself I think we should do it as soon as we have an agreement :). About creating new Packagist package and abandoning the previous one: we can do it soon after package is moved and 1.8.0 sounds reasonable if we can manage it in time - the thing is I need to coordinate this with Facebook, as they are maintainers of the current Packagist package and only they can mark it as abandoned. |
The repository was just transferred to https://github.com/php-webdriver/php-webdriver 🎉 I've just created #733 but few other changes must follow - please allow me few days to sort everything out and setup what we need. |
📢 So the repository has been renamed, package name changed and previous package has been marked as abandoned on Packagist. What you need to do in your composer.json is to replace "require": {
- "facebook/webdriver": "(version you use)",
+ "php-webdriver/webdriver": "(version you use)",
} and run |
Fixes: #15791 Ref: php-webdriver/php-webdriver#735 Ref: php-webdriver/php-webdriver#730 Signed-off-by: William Desportes <[email protected]>
Despite the name,
facebook/php-webdriver
is few last years not developed by Facebook anymore. All current active maintainers are volunteers not associated with Facebook.However because of historic reasons the repository is still under facebook organization on Github. This cause several limitations, for example:
community
(becausemaster
branch is reserved for archived version of the repository from times it was actively used by FB itself), which is quite confusingetc.
Facebook (via @gfosco) agreed to transfer the repository out of facebook organization. This will also allow us to build more sustainable team of maintainers and better manage our community efforts.
👉 The new repository name will probably be
php-webdriver/php-webdriver
👈.We also discussed with @christian-bromann possibility of sharing organization
webdriver
and call itwebdriver/php-webdriver
, however this in my opinion does not have many advantages, maybe a bit shorter name :-). Standalone organization will however provide more freedom for our needs.The renaming should not have impact on URLs, git etc. - GitHub provides redirections after repository is renamed, so everything should still work.
Also following the change, we will also rename the packagist repository from
facebook/webdriver
probably tophp-webdriver/webdriver
. However this is not simple process (packagist packages cannot be simply renamed, they must be submitted under new name and the old one need to be marked as abandoned). So I'm thinking about postponing this change to 2.x - but we will see, it may happen sooner.💬 Any ideas, questions, recommendations? I'd like to hear opinions from other contributors and the community as well!
The text was updated successfully, but these errors were encountered: