Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix translation on str_ireplace #197

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

manuelodermatt
Copy link
Contributor

There is a translation problem with "black" to "schwarz".

@@ -133,7 +133,7 @@
<![CDATA[
<?php
$bodytag = str_ireplace("%body%", "schwarz", "<body text=%BODY%>");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that "schwarz" should not have been translated here; after all, "black" is a valid value for the text attribute, but "schwarz" is not. (And of course, that attribute is long deprecated, but that's something to fix in doc-en first.)

@msamesch
Copy link
Contributor

Thanks a lot for the fix.

@msamesch msamesch merged commit 517faf2 into php:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants