Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W.I.P: PHP 8.4: Add ReflectionConstant stubs #4040

Merged
merged 16 commits into from
Dec 3, 2024
Merged

W.I.P: PHP 8.4: Add ReflectionConstant stubs #4040

merged 16 commits into from
Dec 3, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 11, 2024

@iluuu1994 if you could fill in the docs

@Girgias Girgias force-pushed the reflection-constant-8.4 branch from 423010d to 79b8e24 Compare November 11, 2024 14:53
@Girgias Girgias added this to the PHP 8.4 milestone Nov 11, 2024
@iluuu1994 iluuu1994 self-assigned this Dec 2, 2024
@Girgias Girgias force-pushed the reflection-constant-8.4 branch from 79b8e24 to 7450726 Compare December 2, 2024 14:02
@Girgias Girgias force-pushed the reflection-constant-8.4 branch from 7450726 to 57ceb42 Compare December 2, 2024 14:15
@Girgias Girgias mentioned this pull request Dec 2, 2024
Open
@iluuu1994
Copy link
Member

@Girgias May I ask you to review this one as well? I found some inconsistencies in the pages I copied from. Namely, <refpurpose> is quite variable in how lengthy it is. Can you clarify whether a concise or detailed description is preferred?

Girgias
Girgias commented Dec 3, 2024
View reviewed changes
Copy link
Member Author

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, refpurposes should be short-ish, as they appear
image
next to the link to visit the page

reference/reflection/reflectionconstant/getfilename.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionconstant/isdeprecated.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionconstant/tostring.xml Outdated Show resolved Hide resolved
@iluuu1994
Copy link
Member

Done.

@Girgias Girgias merged commit c477749 into php:master Dec 3, 2024
2 checks passed
@Girgias Girgias deleted the reflection-constant-8.4 branch December 3, 2024 16:16
@Girgias
Copy link
Member Author

Girgias commented Dec 3, 2024

Thank you!

@siwa32 siwa32 mentioned this pull request Dec 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 left review comments

Assignees

@iluuu1994 iluuu1994

Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @iluuu1994