Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Pcntl::QosClass #4095

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[PHP 8.4] Pcntl::QosClass #4095

merged 1 commit into from
Nov 18, 2024

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen added this to the PHP 8.4 milestone Nov 18, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but lgtm

Comment on lines +10 to +11
The <enumname>QosClass</enumname> enum is used to specify the user process
priority with <function>pcntl_setqos_class</function>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this function only take one parameter? If not might be good to reference said parameter here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it does because this is the current process implictly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. :)

@devnexen devnexen merged commit cb0823d into php:master Nov 18, 2024
2 checks passed
@devnexen devnexen deleted the pcntl_qosclass branch November 30, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants