Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4: Single underscore as class name is deprecated #4099

Merged
merged 1 commit into from
Nov 20, 2024
Merged

PHP 8.4: Single underscore as class name is deprecated #4099

merged 1 commit into from
Nov 20, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 20, 2024

No description provided.

@Girgias Girgias requested a review from cmb69 November 20, 2024 01:58
@Girgias Girgias mentioned this pull request Nov 20, 2024
Open
@Girgias Girgias added this to the PHP 8.4 milestone Nov 20, 2024
cmb69
cmb69 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd put the sentence about the deprecation at the bottom of this paragraph, but it is okay as is.

@Girgias Girgias merged commit 2f85d57 into php:master Nov 20, 2024
2 checks passed
@Girgias Girgias deleted the underscore-classname-dep branch November 20, 2024 13:31
@KentarouTakeda KentarouTakeda mentioned this pull request Nov 22, 2024
Open
@siwa32 siwa32 mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @cmb69