[PHP 8.3] opcache.preload_user is not required when run as root
#4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
preload-user-root
branch
from
c8d2e0c to
d984285
Compare
jimwins
requested changes
Dec 4, 2024
reference/opcache/ini.xml
Outdated
Comment on lines
968
to
969
| As of PHP 8.3.0 and when using the CLI or phpdbg SAPIs, the directive isn't required | ||
| by the preloading to be set when running as root. |
There was a problem hiding this comment.
Suggested change
| As of PHP 8.3.0 and when using the CLI or phpdbg SAPIs, the directive isn't required | |
| by the preloading to be set when running as root. | |
| As of PHP 8.3.0, this directive does not need to be set in order to allow preloading while | |
| running as root when using the &cli.sapi; or <link linkend="book.phpdb">phpdbg SAPI</link>. |
Maybe we don't even need to bump this out as a <note> but just add the sentence to the preceding paragraph.
There was a problem hiding this comment.
Works for me!
alexandre-daubois
force-pushed
the
preload-user-root
branch
from
d984285 to
c867028
Compare
jimwins
approved these changes
Dec 5, 2024
reference/opcache/ini.xml
Outdated
Comment on lines
964
to
966
| <literal>root</literal>. As of PHP 8.3.0, this directive does not need to be set in order | ||
| to allow preloading while running as root when using the &cli.sapi; or | ||
| <link linkend="book.phpdb">phpdbg SAPI</link>. |
There was a problem hiding this comment.
You should start the sentence on a line of its own. (It's a convention called "semantic line breaks" that should help with keeping down formatting churn for translations.)
LGTM with that change.
There was a problem hiding this comment.
I wasn't aware this had a name. Thank you Jim, it's updated!
alexandre-daubois
force-pushed
the
preload-user-root
branch
from
c867028 to
4b3268e
Compare
siwa32
added a commit
to siwa32/doc-ja
that referenced
this pull request
Dec 28, 2024
KentarouTakeda
pushed a commit
to php/doc-ja
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2796