Use "unit type" instead of "value type" #4332
Open
+25
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
force-pushed
the
unit-types
branch
from
713e49c to
0704534
Compare
TimWolla
reviewed
Jan 10, 2025
Comment on lines
70
to
85
| <listitem> | ||
| <simpara><type>true</type></simpara> | ||
| <simpara> | ||
| <link linkend="language.types.unit">Unit types</link> | ||
| </simpara> | ||
| <itemizedlist> | ||
| <listitem> | ||
| <simpara><type>false</type></simpara> | ||
| </listitem> | ||
| <listitem> | ||
| <simpara><type>true</type></simpara> | ||
| </listitem> | ||
| <listitem> | ||
| <simpara><type>null</type></simpara> | ||
| </listitem> | ||
| </itemizedlist> | ||
| </listitem> |
There was a problem hiding this comment.
I disagree with this change, since gettype(false) returns boolean. Thus the boolean type is not simply the union of the true and the false type, but an independent type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4077
https://en.wikipedia.org/wiki/Unit_type