Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP8.4] DOMXPath::quote()の翻訳 #192

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

Ippey
Copy link
Contributor

@Ippey Ippey commented Nov 24, 2024

php/doc-en#3909 の変更を反映しました。

<refsect1 role="examples">
&reftitle.examples;
<example>
<title>引用符付きの属性の変換</title>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここだけ、ちょっと意訳だとは思っています。他に良い言い回しあれば🙏

原文

   <title>Matching attribute value with quotes</title>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気付いて頂いてありがとうございます。意訳というか、これ、原文の時点で不正確または曖昧な気がしますね…

Suggested change
<title>引用符付きの属性の変換</title>
<title>引用符を含む属性値の変換</title>

これでにしてみます。意味としては正確なはず。

他に良いの思い浮かんだらいつでも仰ってください。

Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
原文が少し微妙だった気もしますね。おつかれさまでした!

@KentarouTakeda KentarouTakeda merged commit 2db999a into php:master Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants