Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert odbc_bindcols() function to void #13900

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Apr 6, 2024

Carved off from #12040

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@NattyNarwhal NattyNarwhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. I'm assuming we can't do anything sane error-handling wise if SQLBindCol fails anyways.

@kocsismate kocsismate merged commit 365e211 into php:master Apr 7, 2024
10 checks passed
@kocsismate kocsismate deleted the odbc-bindcols-void branch April 7, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants