-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GH-16955: Use ephemeral ports for OpenSSL server client tests #17180
Conversation
If there are only three left, I'm fine with manually choosing hard-coded port numbers, or adding a conflict marker. |
e2422cb
to
f4c2104
Compare
I rewrote that stream_context_tcp_nodelay_server.phpt which was just wrong and then added support for multiple workers which fixes bug77390.phpt . It's a bit more complex now but it works. The only one left is stream_server_reneg_limit.phpt but that's skipped on Windows. It might need some rewrite or we will just eventually drop it (reneg is not really used and not even supported in TLS 1.3). I will leave it for now and if there are any issues with it, I will look into it. |
hmm that stream one no longer works on Windows. Will check it out next week. Also will need to check if there are more tests in later versions. |
See #17193.
I'll have a look as soon as possible. |
I have not been able to reproduce failing of stream_context_tcp_nodelay_server.phpt locally, so I've triggered the Windows job again to check whether this is flaky.
Indeed; in master there are also gh11418.phpt and bug51056.phpt (and maybe more). |
stream_context_tcp_nodelay_server.phpt failed again for the same reason (no output). Might be a crash in the server code, or due to writing to STDERR (could use |
fdbaf8c
to
89534a0
Compare
And refactor some client server tests.
0edf4fd
to
deb1498
Compare
@cmb69 So I did a bit of debugging and in this build https://github.com/php/php-src/actions/runs/12559675194/job/35015813633 with extra debug output, it gave me:
I decided to skip it for now on Windows so I can get it merged as I need those changes for another thing (well I don't want to port that thing later) that I'm looking to and created #17308 which debug output. Not sure at the moment why php-src/ext/openssl/tests/ServerClientTestCase.inc Lines 70 to 77 in b873176
|
This introduces usage of ephemeral port for majority of OpenSSL test.
The only tests that need more work are following: