sapi/cli: Don't set ini-settings mid-expression in interactive shell #17389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in the interactive shell (
php -a
) where the prompt character shown after setting an ini-setting while in the middle of an expression (having pressed enter after an unfinished quote/bracket) would always incorrectly be>
.Here is a demonstration of the current behavior:
Notice how the last prompt is
php >
although it should bephp "
since we are still in the middle of a string.This PR changes such that the setting is just ignored as long as your expression is unfinished: