Add check for constant PGRES_TUPLES_CHUNK to fix compilation failures #17540
Conversation
|
Seems correct thanks, I ll have a look soon-ish. Would you be able to target PHP-8.4 instead ? |
I could do a PR for 8.4, is that preferred to master and then back-porting it? I was under the impression that PRs should be against master but that knowledge is probably outdated |
|
For fixes (inclucing build bugs), we target to the lowest branch the fix applies to. However if it is an issue for you to change target branch, I ll manage at commit time it s fairly small no worries :) |
chschneider
requested review from
kocsismate,
dstogov,
arnaud-lb,
bukka,
nielsdos,
Girgias,
TimWolla,
zeriyoshi,
SakiTakamachi,
NattyNarwhal,
kamil-tekiela,
alexdowad,
youkidearitai,
derickr and
adoy
as code owners
|
Eventually it might be best to redo a proper PR for PHP-8.4 directly. |
|
Hmm, changing the target branch seemed to mess up the PR as hundred of changed files were shown. I think it is easier if I leave it at master, no? Or I could delete the PR and create a new one for 8.4 |
|
whatever suits you best, I ll review it in few dozen of minutes. Cheers. |
nielsdos
removed request for
derickr,
TimWolla,
youkidearitai,
arnaud-lb,
alexdowad,
dstogov,
NattyNarwhal,
kocsismate,
kamil-tekiela,
nielsdos,
Girgias,
zeriyoshi and
SakiTakamachi
|
Thanks ! |
We have an OpenSUSE 15.6 installation with libpq5 installed (the current version being libpq5-17.2-..., i.e. compatible with postgresql17).
But as the current version of postgis does not work properly with postgresql17 so we are currently stuck with the packages postgresql16 and postgresql16-devel.
The file ext/pgsql/config.m4 only checks for the function PQsetChunkedRowsMode but the header files of postgresql16-devel does not define the constant PGRES_TUPLES_CHUNK in libpq-fe.h which leads to a compilation failure.
I added a check for PGRES_TUPLES_CHUNK to avoid this while keeping the feature enabled if the include file declares the constant.