Convert FTP connection resource to an opaque object #5945
Closed
+293
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Parking this here as part of php/php-tasks#6 |
kocsismate
reviewed
Aug 5, 2020
sgolemon
force-pushed
the
sgolemon.conversion.ftp
branch
2 times, most recently
from
3724367 to
6dadf6d
Compare
cmb69
reviewed
Aug 5, 2020
kocsismate
reviewed
Aug 5, 2020
41 tasks
sgolemon
force-pushed
the
sgolemon.conversion.ftp
branch
3 times, most recently
from
94031c1 to
ec1e27f
Compare
nikic
reviewed
Aug 6, 2020
sgolemon
force-pushed
the
sgolemon.conversion.ftp
branch
from
ec1e27f to
3d103dd
Compare
|
The failure on Travis looks legitimate. |
Legit, but slightly unrelated. I noticed this while writing the test and should have done something about it (and will do now that it's in my way). The test server that's spawned out in another process is also producing output under happy-path conditions which is able to interleave with the actual test's output in a non-deterministic ways. I'll look for (or add) a silencer for it. |
sgolemon
force-pushed
the
sgolemon.conversion.ftp
branch
from
3d103dd to
d5e8d48
Compare
|
The reason it was noisy is that our mock server doesn't like a disconnect without auth. Silly test servers. |
nikic
approved these changes
Aug 13, 2020
|
Merged as b4503fb |
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions] passed, it is possible to rename the new `\FTPConnection` to `\FTP` namespace. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, it is possible to rename the new `\FTPConnection` to `\FTP` namespace. This also adds the entry to `./UPGRADING` file. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, it is possible to rename the new `\FTPConnection` class to `\FTP` namespace. This also adds the entry to `./UPGRADING` file. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`. This also adds an entry to `./UPGRADING` file. Related: php#6925, php#5945
nikic
pushed a commit
that referenced
this pull request
May 8, 2021
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`. This also adds an entry to `./UPGRADING` file. Related: #6925, #5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) RFC. Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
nikic
pushed a commit
that referenced
this pull request
May 9, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: #6925, #5945, #6960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.