Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #81200 ReflectionMethod::isStatic belongs on ReflectionFunctionAbstract #7196

Closed
wants to merge 1 commit into from

Conversation

krakjoe
Copy link
Member

@krakjoe krakjoe commented Jun 25, 2021

Ref #7193

@krakjoe krakjoe added the Bug label Jun 25, 2021
@krakjoe krakjoe changed the title Fix bug #81200 ReflectionMethod::isStatic belongs on ReflectionFuncti… Fix bug #81200 ReflectionMethod::isStatic belongs on ReflectionFunctionAbstract Jun 25, 2021
@Girgias
Copy link
Member

Girgias commented Jun 25, 2021

Can this land in PHP 7.4/8.0? Or is that an ABI break?

@krakjoe
Copy link
Member Author

krakjoe commented Jun 25, 2021

Can this land in PHP 7.4/8.0? Or is that an ABI break?

No ABI break, it can go in lower branches.

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't think a backport is justified here.

@krakjoe
Copy link
Member Author

krakjoe commented Jun 28, 2021

Merged as aad0d26

No backport performed ... I wasn't sure about that either.

Thanks.

@krakjoe krakjoe closed this Jun 28, 2021
@orklah orklah mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants