-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Document platform requirement in composer.json
#408
Conversation
aaf5f14
to
009dae2
Compare
composer.json
009dae2
to
cb9068a
Compare
Are there any objections to merging this pull request? |
Why is composer.lock committed? |
cb9068a
to
2de9a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally in favor of adding a composer.json, and if we declare config.platform.php, committing composer.lock appears to be a good idea as well.
2de9a9c
to
14ab35e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is fine for me.
Thank you! |
Thank you, @carusogabriel, @cmb69, @Girgias, and @kamil-tekiela! |
This pull request
composer.json
Follows #606 (comment).
πββοΈ This project currently does not use
composer
to manage its dependencies, but it does not need to stay that way. Apart from usingcomposer
to manage dependencies,composer.json
also serves documentation purposes. For a start, I propose to addcomposer.json
with platform requirements - we can take it from there, if that make sense for you.