Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Document platform requirement in composer.json #408

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented May 25, 2021

This pull request

  • documents the platform requirement in composer.json

Follows #606 (comment).

πŸ’β€β™‚οΈ This project currently does not use composer to manage its dependencies, but it does not need to stay that way. Apart from using composer to manage dependencies, composer.json also serves documentation purposes. For a start, I propose to add composer.json with platform requirements - we can take it from there, if that make sense for you.

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@localheinz localheinz force-pushed the feature/composer branch 2 times, most recently from aaf5f14 to 009dae2 Compare May 25, 2021 16:20
@localheinz localheinz changed the title Enhancement: Document platform requirement in composer.json Enhancement: Document platform requirement in composer.json Dec 21, 2021
@localheinz
Copy link
Contributor Author

Are there any objections to merging this pull request?

@kamil-tekiela
Copy link
Member

Why is composer.lock committed?

@localheinz
Copy link
Contributor Author

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of adding a composer.json, and if we declare config.platform.php, committing composer.lock appears to be a good idea as well.

composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is fine for me.

composer.json Show resolved Hide resolved
@cmb69 cmb69 merged commit d47ac32 into php:master Jul 8, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 8, 2022

Thank you!

@localheinz localheinz deleted the feature/composer branch July 8, 2022 18:36
@localheinz
Copy link
Contributor Author

Thank you, @carusogabriel, @cmb69, @Girgias, and @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants