Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding excluding dependencies as parameters #220

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

AlessandroMinoccheri
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri commented Dec 22, 2021

In this PR I have added a second parameter to this expression NotHaveDependencyOutsideNamespace

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the add-excluding-dependencies-params branch 4 times, most recently from 0867253 to 7243e11 Compare December 23, 2021 10:26
@AlessandroMinoccheri AlessandroMinoccheri force-pushed the add-excluding-dependencies-params branch from 7243e11 to dfe9eed Compare December 23, 2021 12:38
@AlessandroMinoccheri AlessandroMinoccheri force-pushed the add-excluding-dependencies-params branch from dfe9eed to 9a00890 Compare December 23, 2021 14:29
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #220 (5030aca) into main (9fe5038) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #220      +/-   ##
============================================
+ Coverage     92.64%   92.67%   +0.02%     
- Complexity      302      303       +1     
============================================
  Files            51       51              
  Lines           775      778       +3     
============================================
+ Hits            718      721       +3     
  Misses           57       57              
Impacted Files Coverage Δ
src/Expression/ForClasses/Extend.php 91.66% <ø> (ø)
src/Expression/ForClasses/NotExtend.php 85.71% <ø> (ø)
...n/ForClasses/NotHaveDependencyOutsideNamespace.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe5038...5030aca. Read the comment docs.

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the add-excluding-dependencies-params branch from 9a00890 to 5030aca Compare December 23, 2021 14:32
Copy link
Collaborator

@fain182 fain182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! 👌

@AlessandroMinoccheri AlessandroMinoccheri merged commit 6dc45a2 into main Dec 23, 2021
@AlessandroMinoccheri AlessandroMinoccheri deleted the add-excluding-dependencies-params branch December 23, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants