Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing property type into docblocks #309

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

AlessandroMinoccheri
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri commented Nov 12, 2022

This PR can fix the second docblock problems explained in this issue: #307 about @var --> Not detected

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the parse-dependencies-in-docblocks branch 3 times, most recently from e88c346 to 4f74c38 Compare November 12, 2022 23:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Merging #309 (ac3e047) into main (d92de8e) will decrease coverage by 2.72%.
The diff coverage is 73.54%.

@@             Coverage Diff              @@
##               main     #309      +/-   ##
============================================
- Coverage     95.75%   93.02%   -2.73%     
- Complexity      407      475      +68     
============================================
  Files            59       60       +1     
  Lines          1106     1261     +155     
============================================
+ Hits           1059     1173     +114     
- Misses           47       88      +41     
Impacted Files Coverage Δ
src/Analyzer/FileParser.php 85.71% <ø> (ø)
src/Analyzer/FileParserFactory.php 100.00% <ø> (ø)
src/Analyzer/FileVisitor.php 82.65% <ø> (ø)
src/Analyzer/NameResolver.php 73.54% <73.54%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the parse-dependencies-in-docblocks branch 4 times, most recently from 2ed3455 to c4e7828 Compare November 17, 2022 07:24
using nameresolver copied
@AlessandroMinoccheri AlessandroMinoccheri force-pushed the parse-dependencies-in-docblocks branch from c4e7828 to ac3e047 Compare November 20, 2022 20:10
@AlessandroMinoccheri AlessandroMinoccheri merged commit 071d9f9 into main Nov 20, 2022
@AlessandroMinoccheri AlessandroMinoccheri deleted the parse-dependencies-in-docblocks branch November 20, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants