Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression with pattern validation #359

Merged
merged 3 commits into from
Feb 17, 2023
Merged

regression with pattern validation #359

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7ca612
adds test with wildcards
fain182 Feb 16, 2023
398fb86
namespace can contains numbers too
fain182 Feb 17, 2023
3471d21
support all the valid class name characters
fain182 Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyzer/FullyQualifiedClassName.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@ public static function fromString(string $fqcn): self

public function isNotAValidPattern(string $pattern): bool
{
return 0 === preg_match('/^([A-Za-z]|\\\\|\*|\?)*$/', $pattern);
return 0 === preg_match('/^([A-Za-z0-9]|\\\\|\*|\?)*$/', $pattern);
}
}
15 changes: 15 additions & 0 deletions tests/Unit/Expressions/ForClasses/ExtendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ public function test_it_should_return_no_violation_on_success(): void
self::assertEquals(0, $violations->count());
}

public function test_it_should_work_with_wildcards(): void
{
$extend = new Extend('My\B14*');

$classDescription = (new ClassDescriptionBuilder())
->setClassName('My\Class')
->setExtends('My\B14Class', 10)
->build();

$violations = new Violations();
$extend->evaluate($classDescription, $violations, 'because');

self::assertEquals(0, $violations->count());
}

public function test_it_should_return_violation_error_when_argument_is_a_regex(): void
{
$extend = new Extend('App\Providers\(Auth|Event|Route|Horizon)ServiceProvider');
Expand Down