Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed "IsFinal" for Traits #380

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fixed "IsFinal" for Traits #380

merged 1 commit into from
Apr 20, 2023

Conversation

sebastianstucke87
Copy link
Contributor

Fixed \Arkitect\Expression\ForClasses\IsFinal because:

  • Traits can not be final

AlessandroMinoccheri
AlessandroMinoccheri approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AlessandroMinoccheri AlessandroMinoccheri merged commit da20cdc into phparkitect:main Apr 20, 2023
@sebastianstucke87 sebastianstucke87 deleted the traits_can_not_be_final branch April 20, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroMinoccheri AlessandroMinoccheri AlessandroMinoccheri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianstucke87 @AlessandroMinoccheri