Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Anonymous class extends is parsed instead of class extends #390

Merged
merged 2 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Analyzer/FileVisitor.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public function enterNode(Node $node): void
->addInterface($interface->toString(), $interface->getLine());
}

if (null !== $node->extends) {
if (!$node->isAnonymous() && null !== $node->extends) {
$this->classDescriptionBuilder
->setExtends($node->extends->toString(), $node->getLine());
}
Expand Down
29 changes: 29 additions & 0 deletions tests/Unit/Analyzer/FileVisitorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,35 @@ class Animal
class Cat extends Animal
{

}
EOF;

/** @var FileParser $fp */
$fp = FileParserFactory::createFileParser(TargetPhpVersion::create('7.1'));
$fp->parse($code, 'relativePathName');

$cd = $fp->getClassDescriptions()[1];

$this->assertEquals('Root\Animals\Animal', $cd->getExtends()->toString());
}

public function test_it_should_not_parse_extends_from_insider_anonymousclass(): void
{
$code = <<< 'EOF'
<?php

namespace Root\Animals;

class Animal
{
}

class Cat extends Animal
{
public function methodWithAnonymous(): void
{
$obj = new class extends \stdClass {};
}
}
EOF;

Expand Down