Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exclude root #423

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

notcgi
Copy link
Contributor

@notcgi notcgi commented Mar 20, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (b78ecce) to head (44c9c17).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #423      +/-   ##
============================================
+ Coverage     94.19%   94.20%   +0.01%     
- Complexity      582      587       +5     
============================================
  Files            69       69              
  Lines          1533     1536       +3     
============================================
+ Hits           1444     1447       +3     
  Misses           89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlessandroMinoccheri
Copy link
Member

Hi @notcgi can you please fix the CI?

@notcgi
Copy link
Contributor Author

notcgi commented Mar 20, 2024

Hi @notcgi can you please fix the CI?

done

@fain182
Copy link
Collaborator

fain182 commented Mar 21, 2024

Exclude root namsepace is not the same thing as excluding the PHP built-in classes... but anyway is a solution we can evaluate.

@AlessandroMinoccheri
Copy link
Member

@notcgi when do you think is useful to exclude root classes?

@notcgi
Copy link
Contributor Author

notcgi commented Mar 22, 2024

@notcgi when do you think is useful to exclude root classes?

Domain and Application layers can have dependencies like Datetime(-Immutable), Exception, Throwable, RuntimeException, UnitEnum etc

@AlessandroMinoccheri
Copy link
Member

Can you please also update the doc in this PR with this new possible feature please @notcgi ?

@AlessandroMinoccheri AlessandroMinoccheri merged commit c316dee into phparkitect:main Apr 30, 2024
17 checks passed
@AlessandroMinoccheri
Copy link
Member

Thank you @notcgi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants