-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude root #423
Add exclude root #423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
============================================
+ Coverage 94.19% 94.20% +0.01%
- Complexity 582 587 +5
============================================
Files 69 69
Lines 1533 1536 +3
============================================
+ Hits 1444 1447 +3
Misses 89 89 ☔ View full report in Codecov by Sentry. |
Hi @notcgi can you please fix the CI? |
done |
Exclude root namsepace is not the same thing as excluding the PHP built-in classes... but anyway is a solution we can evaluate. |
@notcgi when do you think is useful to exclude root classes? |
Domain and Application layers can have dependencies like Datetime(-Immutable), Exception, Throwable, RuntimeException, UnitEnum etc |
Can you please also update the doc in this PR with this new possible feature please @notcgi ? |
Thank you @notcgi |
#338