Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "IsReadonly" for interfaces, traits and enums #426

Merged
merged 2 commits into from
May 8, 2024
Merged

Fixed "IsReadonly" for interfaces, traits and enums #426

merged 2 commits into from
May 8, 2024

Conversation

sebastianstucke87
Copy link
Contributor

Fixed \Arkitect\Expression\ForClasses\IsReadonly because:

  • interfaces can not be readonly
  • traits can not be readonly
  • enums can not be readonly
  • tests where incorrect

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (b78ecce) to head (a4b5f8c).
Report is 3 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #426   +/-   ##
=========================================
  Coverage     94.19%   94.19%           
- Complexity      582      585    +3     
=========================================
  Files            69       69           
  Lines          1533     1533           
=========================================
  Hits           1444     1444           
  Misses           89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianstucke87 sebastianstucke87 changed the title fixed "IsReadonly" for interfaces, traits and enums Fixed "IsReadonly" for interfaces, traits and enums Mar 30, 2024
@AlessandroMinoccheri
Copy link
Member

Hi @sebastianstucke87 can you please fix red checks?

Copy link
Member

@AlessandroMinoccheri AlessandroMinoccheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AlessandroMinoccheri AlessandroMinoccheri merged commit 1240ec9 into phparkitect:main May 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants