Prevent crashes for unknown classes

phpstan · Mar 11, 2019 · 6f599c2 · 6f599c2
1 parent f7ce984
commit 6f599c2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/src/Rules/Doctrine/ORM/MagicRepositoryMethodCallRule.php b/src/Rules/Doctrine/ORM/MagicRepositoryMethodCallRule.php
@@ -48,6 +48,10 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		$methodName = $methodNameIdentifier->toString();
+		if (!$this->broker->hasClass($calledOnType->getClassName())) {
+			return [];
+		}
+
 		$repositoryReflectionClass = $this->broker->getClass($calledOnType->getClassName());
 		if ($repositoryReflectionClass->hasNativeMethod($methodName)) {
 			return [];

diff --git a/src/Type/Doctrine/ObjectRepositoryDynamicReturnTypeExtension.php b/src/Type/Doctrine/ObjectRepositoryDynamicReturnTypeExtension.php
@@ -53,24 +53,26 @@ public function getTypeFromMethodCall(
 		}
 
 		$methodName = $methodReflection->getName();
-		$repositoryClassReflection = $this->broker->getClass($calledOnType->getClassName());
-		if (
-			(
+		if ($this->broker->hasClass($calledOnType->getClassName())) {
+			$repositoryClassReflection = $this->broker->getClass($calledOnType->getClassName());
+			if (
 				(
-					strpos($methodName, 'findBy') === 0
-					&& strlen($methodName) > strlen('findBy')
-				) || (
-					strpos($methodName, 'findOneBy') === 0
-					&& strlen($methodName) > strlen('findOneBy')
+					(
+						strpos($methodName, 'findBy') === 0
+						&& strlen($methodName) > strlen('findBy')
+					) || (
+						strpos($methodName, 'findOneBy') === 0
+						&& strlen($methodName) > strlen('findOneBy')
+					)
 				)
-			)
-			&& $repositoryClassReflection->hasNativeMethod($methodName)
-		) {
-			return ParametersAcceptorSelector::selectFromArgs(
-				$scope,
-				$methodCall->args,
-				$repositoryClassReflection->getNativeMethod($methodName)->getVariants()
-			)->getReturnType();
+				&& $repositoryClassReflection->hasNativeMethod($methodName)
+			) {
+				return ParametersAcceptorSelector::selectFromArgs(
+					$scope,
+					$methodCall->args,
+					$repositoryClassReflection->getNativeMethod($methodName)->getVariants()
+				)->getReturnType();
+			}
 		}
 
 		if (!$calledOnType instanceof ObjectRepositoryType) {