EntityNotFinalRule - only entities that are final on language level s…

…hould be considered
phpstan · May 20, 2021 · a3b36bd · a3b36bd
1 parent 9d798be
commit a3b36bd
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 1 deletion.
diff --git a/src/Rules/Doctrine/ORM/EntityNotFinalRule.php b/src/Rules/Doctrine/ORM/EntityNotFinalRule.php
@@ -34,7 +34,7 @@ public function processNode(Node $node, Scope $scope): array
 		if ($classReflection === null) {
 			throw new \PHPStan\ShouldNotHappenException();
 		}
-		if (!$classReflection->isFinal()) {
+		if (!$classReflection->isFinalByKeyword()) {
 			return [];
 		}
 

diff --git a/tests/Rules/Doctrine/ORM/EntityNotFinalRuleTest.php b/tests/Rules/Doctrine/ORM/EntityNotFinalRuleTest.php
@@ -45,6 +45,11 @@ public function ruleProvider(): Iterator
 			],
 		];
 
+		yield 'final annotated entity' => [
+			__DIR__ . '/data/FinalAnnotatedEntity.php',
+			[],
+		];
+
 		yield 'final non-entity' => [
 			__DIR__ . '/data/FinalNonEntity.php',
 			[],

diff --git a/tests/Rules/Doctrine/ORM/data/FinalAnnotatedEntity.php b/tests/Rules/Doctrine/ORM/data/FinalAnnotatedEntity.php
@@ -0,0 +1,22 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @final
+ * @ORM\Entity()
+ */
+class FinalAnnotatedEntity
+{
+	/**
+	 * @ORM\Id()
+	 * @ORM\GeneratedValue()
+	 * @ORM\Column(type="integer")
+	 *
+	 * @var int
+	 */
+	private $id;
+
+}