GetNonVirtualPropertyHookReadRule - do not report if get hook is not …

…present at all
phpstan · Jan 2, 2025 · b614f70 · b614f70
1 parent a742e51
commit b614f70
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/Rules/Properties/GetNonVirtualPropertyHookReadRule.php b/src/Rules/Properties/GetNonVirtualPropertyHookReadRule.php
@@ -70,7 +70,17 @@ public function processNode(Node $node, Scope $scope): array
 
 		$errors = [];
 		foreach ($node->getProperties() as $propertyNode) {
-			if (!$propertyNode->hasHooks()) {
+			$hasGetHook = false;
+			foreach ($propertyNode->getHooks() as $hook) {
+				if ($hook->name->toLowerString() !== 'get') {
+					continue;
+				}
+
+				$hasGetHook = true;
+				break;
+			}
+
+			if (!$hasGetHook) {
 				continue;
 			}
 

diff --git a/tests/PHPStan/Rules/Properties/data/get-non-virtual-property-hook-read.php b/tests/PHPStan/Rules/Properties/data/get-non-virtual-property-hook-read.php
@@ -46,3 +46,12 @@ class Foo
 	}
 
 }
+
+class GetHookIsNotPresentAtAll
+{
+	public int $i {
+		set {
+			$this->i = $value + 10;
+		}
+	}
+}