Private __clone method isn't considered unused

phpstan · Aug 2, 2020 · cdbed86 · cdbed86
1 parent 8d84146
commit cdbed86
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/src/Rules/DeadCode/UnusedPrivateMethodRule.php b/src/Rules/DeadCode/UnusedPrivateMethodRule.php
@@ -46,7 +46,11 @@ public function processNode(Node $node, Scope $scope): array
 			if (!$method->isPrivate()) {
 				continue;
 			}
-			if ($constructor !== null && $constructor->getName() === $method->name->toString()) {
+			$methodName = $method->name->toString();
+			if ($constructor !== null && $constructor->getName() === $methodName) {
+				continue;
+			}
+			if (strtolower($methodName) === '__clone') {
 				continue;
 			}
 			$methods[$method->name->toString()] = $method;

diff --git a/tests/PHPStan/Rules/DeadCode/UnusedPrivateMethodRuleTest.php b/tests/PHPStan/Rules/DeadCode/UnusedPrivateMethodRuleTest.php
@@ -42,4 +42,9 @@ public function testRule(): void
 		]);
 	}
 
+	public function testBug3630(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-3630.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/DeadCode/data/bug-3630.php b/tests/PHPStan/Rules/DeadCode/data/bug-3630.php
@@ -0,0 +1,10 @@
+<?php
+
+namespace Bug3630;
+
+class HelloWorld
+{
+	private function __clone()
+	{
+	}
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,4 +42,9 @@ public function testRule(): void @@
     		]);
     	}
+    	public function testBug3630(): void
+    	{
+    		$this->analyse([__DIR__ . '/data/bug-3630.php'], []);
+    	}
     }