TooWideMethodReturnTypehintRule - never report in a trait

phpstan · Dec 7, 2023 · e0eb850 · e0eb850
1 parent c30e9a4
commit e0eb850
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Rules/TooWideTypehints/TooWideMethodReturnTypehintRule.php b/src/Rules/TooWideTypehints/TooWideMethodReturnTypehintRule.php
@@ -32,6 +32,9 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		if ($scope->isInTrait()) {
+			return [];
+		}
 		$method = $node->getMethodReflection();
 		$isFirstDeclaration = $method->getPrototype()->getDeclaringClass() === $method->getDeclaringClass();
 		if (!$method->isPrivate()) {

diff --git a/tests/PHPStan/Rules/TooWideTypehints/data/tooWideMethodReturnType-private.php b/tests/PHPStan/Rules/TooWideTypehints/data/tooWideMethodReturnType-private.php
@@ -92,3 +92,20 @@ private function dolor6() {
 	}
 
 }
+
+trait FooTrait
+{
+
+	private function doFoo(): ?int
+	{
+		return 1;
+	}
+
+}
+
+class UsesFooTrait
+{
+
+	use FooTrait;
+
+}