AccessPropertiesRule - tip with article link

phpstan · Mar 31, 2023 · e6e2d1a · e6e2d1a
1 parent 11f8d96
commit e6e2d1a
Show file tree

Hide file tree

Showing 3 changed files with 96 additions and 0 deletions.
diff --git a/src/Rules/Properties/AccessPropertiesRule.php b/src/Rules/Properties/AccessPropertiesRule.php
@@ -143,6 +143,8 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
 			));
 			if ($typeResult->getTip() !== null) {
 				$ruleErrorBuilder->tip($typeResult->getTip());
+			} else {
+				$ruleErrorBuilder->tip('Learn more: <fg=cyan>https://phpstan.org/blog/solving-phpstan-access-to-undefined-property</>');
 			}
 
 			return [

diff --git a/tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php b/tests/PHPStan/Rules/Properties/AccessPropertiesInAssignRuleTest.php
@@ -23,14 +23,17 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
+		$tipText = 'Learn more: <fg=cyan>https://phpstan.org/blog/solving-phpstan-access-to-undefined-property</>';
 		$this->analyse([__DIR__ . '/data/access-properties-assign.php'], [
 			[
 				'Access to an undefined property TestAccessPropertiesAssign\AccessPropertyWithDimFetch::$foo.',
 				10,
+				$tipText,
 			],
 			[
 				'Access to an undefined property TestAccessPropertiesAssign\AccessPropertyWithDimFetch::$foo.',
 				15,
+				$tipText,
 			],
 		]);
 	}
@@ -40,42 +43,52 @@ public function testRuleAssignOp(): void
 		if (PHP_VERSION_ID < 70400) {
 			self::markTestSkipped('Test requires PHP 7.4.');
 		}
+
+		$tipText = 'Learn more: <fg=cyan>https://phpstan.org/blog/solving-phpstan-access-to-undefined-property</>';
 		$this->analyse([__DIR__ . '/data/access-properties-assign-op.php'], [
 			[
 				'Access to an undefined property TestAccessProperties\AssignOpNonexistentProperty::$flags.',
 				15,
+				$tipText,
 			],
 		]);
 	}
 
 	public function testRuleExpressionNames(): void
 	{
+		$tipText = 'Learn more: <fg=cyan>https://phpstan.org/blog/solving-phpstan-access-to-undefined-property</>';
 		$this->analyse([__DIR__ . '/data/properties-from-variable-into-object.php'], [
 			[
 				'Access to an undefined property PropertiesFromVariableIntoObject\Foo::$noop.',
 				26,
+				$tipText,
 			],
 		]);
 	}
 
 	public function testRuleExpressionNames2(): void
 	{
+		$tipText = 'Learn more: <fg=cyan>https://phpstan.org/blog/solving-phpstan-access-to-undefined-property</>';
 		$this->analyse([__DIR__ . '/data/properties-from-array-into-object.php'], [
 			[
 				'Access to an undefined property PropertiesFromArrayIntoObject\Foo::$noop.',
 				42,
+				$tipText,
 			],
 			[
 				'Access to an undefined property PropertiesFromArrayIntoObject\Foo::$noop.',
 				54,
+				$tipText,
 			],
 			[
 				'Access to an undefined property PropertiesFromArrayIntoObject\Foo::$noop.',
 				69,
+				$tipText,
 			],
 			[
 				'Access to an undefined property PropertiesFromArrayIntoObject\Foo::$noop.',
 				110,
+				$tipText,
 			],
 		]);
 	}