-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest Prometheus releases reports duplicate metrics in the rundeck exporter #108
Comments
Hi @BaCaRoZzo, thanks for reporting this. OK, I've just tried in my local environment and it looks like this only happens when the I need to look into it further. |
@BaCaRoZzo, can you confirm your Prometheus version? I ask because after two days of testing, enabling, disabling, and playing with the exporter cache and cache TTL, I've only been able to reproduce the duplicate metrics twice, I've also upgraded my Prometheus to version 3.1.0 and set it to scrape the metrics every 15s. Could you try the latest Prometheus version? |
Hi @phsmith, I'm using the latest There's no plan to port soon but I can give it a try and see if that solves the issue. Which was the version that showed the problem for you? |
Got it! I was running Prometheus 2.52.0 when I got the error. Let me try with the same version as you. By the way, I've noticed that the duplication can be eliminated by having a label in the metrics that can be updated each time the exporter metrics are scraped, I'm just checking out the better way to do this. |
@phsmith so is this a problem with As said, we don't plan to update to So, if a fix for |
Yes, I have found the problem on the Prometheus side regarding duplicate metrics in version 2.x, but it is mainly due to the exporter cache option which sends the same metrics until the cache is invalidated. I've found a way to fix this on the exporter side and will send a fix tonight. |
@phsmith thanks a lot. |
@BaCaRoZzo, I've just released the exporter version v2.8.4 with the fix for this issue. Please give it a try when you have the chance. |
@phsmith apologies for the long wait. The fix seems to be effective. I've deployed the new Thanks so much for your prompt response and the quick fix! |
See prometheus/prometheus#14089 for another example of this issue.
Newer releases of
prometheus
are generating error logs regarding duplicate metrics in the exporter:Using the piped command from prometheus/prometheus#14089 (comment) in the linked issue, we can indeed find out that some metrics repeat themselves. The metrics that repeat for me are:
They either repeat with the same value or different values. The duplication is not continuous but instead it happens for a few scrapes and then disappears. In the following picture you can see how often it happened in the last hour via the
prometheus_target_scrapes_sample_duplicate_timestamp_total
metric:We are currently using release
2.7.0
, although I don't see any change in the newer releases of the exporter that can help with this problem. Since we are alerting onprometheus_target_scrapes_sample_duplicate_timestamp_total
, it is causing quite some noise in our notification channels.Any idea about what can be causing the issue?
The text was updated successfully, but these errors were encountered: