patch winston to suppress padLevels warning

[distalx]

See #winstonjs/winston/issues/1882

This is a fix for #2341

There are other few changes necessary to keep winston up to date with it's version 2.4.5.

Hope this helps :)

Edit:
I've already signed contributor agreement!

cc @CamJN

[distalx]

@CamJN Just floating this on top of your inbox!

[CamJN]

Thanks for reminding me to look at this. Would bumping to 2.4.5 work as an alternative approach that keeps our copy of winston the same as upstream?

[distalx]

@CamJN

Would bumping to 2.4.5 work as an alternative approach that keeps our copy of winston the same as upstream?

No, This issue still persists in 2.4.5. But it would be great if you can update the copy of winston to 2.4.5.
What stopped me from doing is the impression that the phusion-passenger is using a custom or maybe modified version of winston (see). Once you update the winston to 2.4.5, follow this workaround suggested in this comment and it would work.

What I've submitted here is a cherry-picked code from winston branch 2.x. And I've mentioned those PRs in the code.

For a long-term solution, phusion-passenger should consider updating the winston to its latest version which is v3 ATM.
And that might require significant effort because of breaking changes.

[CamJN]

The only changes we made to the vendored winston was removing non-code files and fixing permissions. The content of the module was identical.

[distalx]

I see, Then first we should update the winston to 2.4.5 & then apply this fix.