Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lighttpd mime #2816

Merged
merged 2 commits into from
Jun 29, 2019
Merged

Fix lighttpd mime #2816

merged 2 commits into from
Jun 29, 2019

Conversation

RamSet
Copy link
Member

@RamSet RamSet commented Jun 25, 2019

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Fixed issue related to lighttpd not starting/failing during install due to deprecated parameter in the config (migrated from older versions).

How does this PR accomplish the above?:
Commented out the old perl mime file path and hard coded generic MIME definitions within the config.

What documentation changes (if any) are needed to support this PR?:
None


  • You must follow the template instructions. Failure to do so will result in your pull request being closed.
  • Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.

@dschaper dschaper mentioned this pull request Jun 25, 2019
6 tasks
@dschaper dschaper added the PR: Code Review Required Open Pull Request, needs code reviewd label Jun 25, 2019
@dschaper dschaper added this to the 4.3.1 milestone Jun 25, 2019
@AzureMarker
Copy link
Contributor

Note that the failing test is due to using the latest version of Fedora instead of 29. Fixed by this PR in dev: #2806

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-web-interface-not-displaying-correctly/21087/6

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/rasbian-buster-pi-hole-install-fails/21127/13

@TechWilk
Copy link

Ran into the same problem trying to install on a fresh install of Raspbian Buster.

Managed to fix by simply changing the include_shell line to
include_shell "/usr/share/lighttpd/create-mime.conf.pl" (note conf)

@dschaper
Copy link
Member

Changing the line is just a temporary fix since the file will be overwritten on update/re-install.

@AzureMarker AzureMarker merged commit 1a741f6 into pi-hole:master Jun 29, 2019
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/getting-ready-for-buster/21001/22

1 similar comment
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/getting-ready-for-buster/21001/22

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-blockiert/21255/6

@neuhaus
Copy link

neuhaus commented Jul 12, 2019

Are there any other issues with Raspbian Buster? If not, can Buster be added to the list at https://docs.pi-hole.net/main/prerequesites/#supported-operating-systems ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Code Review Required Open Pull Request, needs code reviewd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants