Skip to content

Commit

Permalink
Correctly build packages for linux-musl-arm64 (dotnet/coreclr#22793)
Browse files Browse the repository at this point in the history
* Correctly build packages for linux-musl-arm64

Also add build-package step to PR.

* Correctly add back if

* Fix build-packages


Commit migrated from dotnet/coreclr@3e8cd50
  • Loading branch information
Jarret Shook authored Feb 23, 2019
1 parent de9e9b3 commit fd61dc5
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
13 changes: 8 additions & 5 deletions eng/build-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,17 @@ jobs:
KeyVaultName: EngKeyVault
SecretsFilter: 'dotnetfeed-storage-access-key-1,microsoft-symbol-server-pat,symweb-symbol-server-pat'

# Build packages
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- script: ./build-packages.sh -BuildArch=$(archType) -BuildType=$(buildConfigUpper) $(crossPackagesArg) -OfficialBuildId=$(Build.BuildNumber) $(portableBuildArg)
displayName: Build packages
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
- script: build-packages.cmd -BuildArch=$(archType) -BuildType=$(buildConfigUpper) -OfficialBuildId=$(Build.BuildNumber)
displayName: Build packages

# Build packages and publish official build
# Publish official build
- ${{ if and(ne(variables['System.TeamProject'], 'public'), ne(variables['Build.Reason'], 'PullRequest')) }}:
- ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
- script: ./build-packages.sh -BuildArch=$(archType) -BuildType=$(buildConfigUpper) $(crossPackagesArg) -OfficialBuildId=$(Build.BuildNumber) $(portableBuildArg)
displayName: Build packages
- script: ./eng/common/build.sh /p:DotNetPublishToBlobFeed=true --ci --restore --projects $(Build.SourcesDirectory)/eng/empty.proj
displayName: Restore blob feed tasks
${{ if eq(parameters.osGroup, 'FreeBSD') }}:
Expand All @@ -162,8 +167,6 @@ jobs:
DotNetCoreSdkDir: /usr/local/dotnet
- ${{ if eq(parameters.osGroup, 'Windows_NT') }}:
# TODO: pass publish feed url and access token in from the internal pipeline
- script: build-packages.cmd -BuildArch=$(archType) -BuildType=$(buildConfigUpper) -OfficialBuildId=$(Build.BuildNumber)
displayName: Build packages
- powershell: eng\common\build.ps1 /p:DotNetPublishToBlobFeed=true -ci -restore -projects $(Build.SourcesDirectory)\eng\empty.proj
displayName: Restore blob feed tasks
- powershell: eng\common\msbuild.ps1 -ci src\publishwitharcade.proj /p:__BuildType=$(buildConfigUpper) /p:__BuildArch=$(archType) /p:OSIdentifier=$(osIdentifier) /p:AzureFeedUrl=$(dotnetfeedUrl) /p:AzureAccountKey=$(dotnetfeedPAT)
Expand Down
7 changes: 7 additions & 0 deletions src/coreclr/build-packages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,13 @@ done

initDistroRid

if [ "${__DistroRid}" = "linux-musl-arm64" ]; then
# ArchGroup is generally determined from parsing {}-{}; however, linux-musl-arm64
# will break this logic. To work around this, pass ArchGroup explicitely.

export ArchGroup=arm64
fi

$__ProjectRoot/dotnet.sh msbuild /nologo /verbosity:minimal /clp:Summary \
/p:__BuildOS=$__BuildOS /flp:v=detailed\;Append\;LogFile=build-packages.log \
/l:BinClashLogger,Tools/Microsoft.DotNet.Build.Tasks.dll\;LogFile=binclash.log \
Expand Down
3 changes: 3 additions & 0 deletions src/coreclr/src/.nuget/dir.props
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@
<OfficialBuildRID Include="linux-arm64">
<Platform>arm64</Platform>
</OfficialBuildRID>
<OfficialBuildRID Include="linux-musl-arm64">
<Platform>arm64</Platform>
</OfficialBuildRID>
<OfficialBuildRID Include="tizen.4.0.0-armel">
<Platform>armel</Platform>
</OfficialBuildRID>
Expand Down

0 comments on commit fd61dc5

Please sign in to comment.