Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP windows: Fix get cookies #2410

Closed

Conversation

kodjodevf
Copy link

Connection with issue(s)

May resolve issue #2314

New implementation to retrieve cookies

For the moment we can retrieve all cookies without specifying the url

Testing and Review Notes

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@kodjodevf
Copy link
Author

I tried to use URL like this :

std::wstring urlW = std::wstring(url.begin(), url.end());
   auto hr = m_cookieManager->GetCookies(
       urlW.c_str(),
       Callback<ICoreWebView2GetCookiesCompletedHandler>(
           [completionHandler, name](HRESULT errorCode, ICoreWebView2CookieList *cookieList)

but it doesn't work

@pichillilorenzo
Copy link
Owner

check #2314 (comment)

@kodjodevf kodjodevf closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants