Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Implemented Search Function using SearchApi #86

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

Arindam200
Copy link
Contributor

Description

I've used SearchAPI to implement the search functionality. Would love to get a review from @jordan-pieces !

Next: Need to filter the array of the code snippets.

This PR fixes #8

@Arindam200 Arindam200 marked this pull request as draft February 16, 2024 21:02
@Arindam200 Arindam200 marked this pull request as ready for review February 18, 2024 07:24
Copy link
Contributor

@jwafu jwafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

setSearchTerm(searchTerm );
let result = await searchSnippetList(searchTerm);
console.log("The Result is "+ result);
console.log(searchTerm);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill handle this here, but a good note in the future is to try and minimize console.logs when finalizing a PR, removing some unnecessary ones that were used in development. 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I forgot to remove those!

I'll keep this in mind.

@jwafu jwafu added new endpoint showing the functionality of a new endpoint community review something that requires feedback from the community labels Feb 21, 2024
@jwafu jwafu merged commit 6902c7f into pieces-app:main Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community review something that requires feedback from the community new endpoint showing the functionality of a new endpoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Search Functionality + Components
2 participants