Use rich cli in runserver #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piercefreeman
force-pushed
the
feature/cli-verbosity
branch
from
f332098 to
43ac126
Compare
piercefreeman
force-pushed
the
feature/cli-verbosity
branch
from
df0a7e9 to
a792e07
Compare
piercefreeman
force-pushed
the
feature/cli-verbosity
branch
from
d2afcf4 to
fb27240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build CLI
This PR cleans up the
runserverbuild processes to make it clearer what is occurring during project compilation and give users a time estimate for the remaining work. Right now we log:The compilation of frontend files in particular is known to take some time, even with our parallel refactor. We show a per-file progress bar to incrementally update the status, which required a refactor to our rust/golang build layer to add a new python callback argument for the javascript builder. Rust handles the parallelism now instead of golang, which avoids the need to do unsafe pointer manipulation during the python->rust->go FFI.
Verbosity
As part of cleaning up the build pipeline, this PR reduces the verbosity of our regular logger to warnings and above. To modify the logging on a per-run basis users can override the MOUNTAINEER_LOG_LEVEL environment variable. This doesn't change the default log level for general instantiations of
setup_logger, in case users are relying on the default level to log everything.MOUNTAINEER_LOG_LEVEL="DEBUG" poetry run runserver