Cancel image download task on cell reuse

pietrocaselani · Jan 13, 2019 · 2936cc6 · 2936cc6
1 parent aa513ab
commit 2936cc6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/CouchTrackerApp/Shows/Progress/ShowProgressCell.swift b/CouchTrackerApp/Shows/Progress/ShowProgressCell.swift
@@ -1,9 +1,11 @@
 import Cartography
 import CouchTrackerCore
+import Kingfisher
 import RxSwift
 
 final class ShowProgressCell: TableViewCell {
   static let identifier = "ShowProgressCell"
+  private var imageTask: DownloadTask?
   private var disposable: Disposable?
 
   var presenter: ShowProgressCellPresenter? {
@@ -17,10 +19,11 @@ final class ShowProgressCell: TableViewCell {
   }
 
   override func prepareForReuse() {
-    super.prepareForReuse()
-
+    imageTask?.cancel()
     posterImageView.image = nil
     disposable = nil
+
+    super.prepareForReuse()
   }
 
   private func handleViewState(_ viewState: ShowProgressCellViewState) {
@@ -41,7 +44,7 @@ final class ShowProgressCell: TableViewCell {
   }
 
   private func showPosterImage(with url: URL) {
-    posterImageView.kf.setImage(with: url)
+    imageTask = posterImageView.kf.setImage(with: url)
   }
 
   let posterImageView = UIImageView()

diff --git a/CouchTrackerApp/Views/PosterAndTitleCell.swift b/CouchTrackerApp/Views/PosterAndTitleCell.swift
@@ -4,18 +4,20 @@ import Kingfisher
 
 public final class PosterAndTitleCell: CollectionViewCell {
   public static let identifier = "PosterAndTitleCell"
+  private var imageTask: DownloadTask?
 
   public var presenter: PosterCellPresenter! {
     didSet {
+      imageTask?.cancel()
       posterImageView.image = nil
       presenter.viewWillAppear()
     }
   }
 
   public override func prepareForReuse() {
-    super.prepareForReuse()
-
+    imageTask?.cancel()
     posterImageView.image = nil
+    super.prepareForReuse()
   }
 
   public let posterImageView = UIImageView()
@@ -58,6 +60,6 @@ extension PosterAndTitleCell: PosterCellView {
   }
 
   public func showPosterImage(with url: URL) {
-    posterImageView.kf.setImage(with: url)
+    imageTask = posterImageView.kf.setImage(with: url)
   }
 }