Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent negative layout results in case the available width is zero #17

Merged

Conversation

danurna
Copy link
Contributor

@danurna danurna commented Feb 21, 2022

Hello there and thanks for this great library. Still got to support iOS 13 so I am glad it exists.

I've stumbled upon the issue of negative frame sizes being requested myself when using the GridStack inside a NavigationView (see related Apple Forum Thread). This is in line with the issue that has already been reported here: #16.

The provided fix is quite simple. Please let me know what you think. Cheers!

Copy link
Owner

@pietropizzi pietropizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I trust the tests pass :). I don't have setup any automation for it.

@pietropizzi pietropizzi merged commit 011a397 into pietropizzi:master Feb 21, 2022
@pietropizzi
Copy link
Owner

pietropizzi commented Feb 21, 2022

@danurna Released this as 0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants