Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #93 in master #95

Merged
merged 5 commits into from
Aug 20, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public void foundUpdateAndDontShowIt(String versionDownloadable) {
* @param versionDownloadable version downloadable from the Store.
*/
@Override
public void upToDate(String versionDownloadable) {
public void returnUpToDate(String versionDownloadable) {
result.setText("Updated\n" + "Version downloadable: " + versionDownloadable + "\nVersion installed: " + getVersionInstalled());
}

Expand All @@ -95,31 +95,31 @@ public void upToDate(String versionDownloadable) {
* @see <a href="https://github.com/rampo/UpdateChecker/issues/1">Issue #1</a>
*/
@Override
public void multipleApksPublished() {
public void returnMultipleApksPublished() {
result.setText("Error #1");
}

/**
* Can't download the store page.
*/
@Override
public void networkError() {
public void returnNetworkError() {
result.setText("Network Error");
}

/**
* Can't find the store page for this app.
*/
@Override
public void appUnpublished() {
public void returnAppUnpublished() {
result.setText("App unpublished");
}

/**
* The check returns null for new version downloadble
*/
@Override
public void storeError() {
public void returnStoreError() {
result.setText("Store Error");
}

Expand Down
34 changes: 27 additions & 7 deletions library/src/main/java/com/rampo/updatechecker/UpdateChecker.java
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public void versionDownloadableFound(String versionDownloadable) {
mLibraryResultCallaback.foundUpdateAndDontShowIt(versionDownloadable);
}
} else { // No new update available
mLibraryResultCallaback.upToDate(versionDownloadable);
mLibraryResultCallaback.returnUpToDate(versionDownloadable);
}

}
Expand All @@ -156,31 +156,31 @@ public void versionDownloadableFound(String versionDownloadable) {
*/
@Override
public void multipleApksPublished() {
mLibraryResultCallaback.multipleApksPublished();
mLibraryResultCallaback.returnMultipleApksPublished();
}

/**
* Can't download the store page.
*/
@Override
public void networkError() {
mLibraryResultCallaback.networkError();
mLibraryResultCallaback.returnNetworkError();
}

/**
* Can't find the store page for this app.
*/
@Override
public void appUnpublished() {
mLibraryResultCallaback.appUnpublished();
mLibraryResultCallaback.returnAppUnpublished();
}

/**
* The check returns null for new version downloadble
*/
@Override
public void storeError() {
mLibraryResultCallaback.storeError();
mLibraryResultCallaback.returnStoreError();
}

/**
Expand Down Expand Up @@ -215,10 +215,30 @@ public void foundUpdateAndDontShowIt(String versionDownloadable) {
* versionDownloadable is equal to manifest versionName -> No new update available.
* Don't show the Notice
*
* @param versionDownloadable version downloadable from the Store.
* @param versionDonwloadable version downloadable from the Store.
*/
@Override
public void upToDate(String versionDownloadable) {
public void returnUpToDate(String versionDonwloadable) {

}

@Override
public void returnMultipleApksPublished() {

}

@Override
public void returnNetworkError() {

}

@Override
public void returnAppUnpublished() {

}

@Override
public void returnStoreError() {

}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,28 +45,28 @@ public interface UpdateCheckerResult {
*
* @param versionDonwloadable version downloadable from the Store.
*/
public void upToDate(String versionDonwloadable);
public void returnUpToDate(String versionDonwloadable);

/**
* Can't get the versionName from the Store.
* See #1
*
* @see <a href="https://github.com/rampo/UpdateChecker/issues/1">Issue #1</a>
*/
public void multipleApksPublished();
public void returnMultipleApksPublished();

/**
* Can't download the store page.
*/
public void networkError();
public void returnNetworkError();

/**
* Can't find the store page for this app.
*/
public void appUnpublished();
public void returnAppUnpublished();

/**
* The check returns null for new version downloadble
*/
public void storeError();
public void returnStoreError();
}