Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add writeMapping, update tutorial, explain source column, convert to LF #444

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

orichters
Copy link
Contributor

Purpose of this PR

  • using different line endings in the package leads to annoyingly large diffs between windows and linux users. Convert everything to LF and make sure with .gitattributes it stays like that
  • improve the tutorial with respect to price indices and the source column, also improve testing on this on by adding a inst/sources.csv file with all options so that can be checked.
  • move adding an interpolation column out of getMapping to make sure one can edit the files with R without adding this column. Instead, add an empty interpolation column if missing in generateIIASASubmission
  • add writeMapping function with correct write.table settings. Add a test that writing and reading all mappings returns the same result.

@orichters orichters changed the title convert everything to LF, update tutorial, explain source column better convert everything to LF, update tutorial, explain source column, add writeMapping Feb 5, 2025
@orichters orichters changed the title convert everything to LF, update tutorial, explain source column, add writeMapping add writeMapping, update tutorial, explain source column, convert to LF Feb 5, 2025
@orichters orichters merged commit 7fe0b6d into pik-piam:master Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant