Return in_view: bool from Viz.update_graphics()

Allows callers to know if they should care about a particular viz rendering call by immediately knowing if the graphics are in view. This turns out super useful particularly when doing dynamic y-ranging overlay calcs.
pikers · Feb 3, 2023 · 325fe3c · 325fe3c
1 parent 28aaaf9
commit 325fe3c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/piker/ui/_dataviz.py b/piker/ui/_dataviz.py
@@ -1061,7 +1061,7 @@ def default_view(
 
             else:
                 log.warning(f'Unknown view state {vl} -> {vr}')
-                return
+                # return
                 # raise RuntimeError(f'Unknown view state {vl} -> {vr}')
 
         else:

diff --git a/piker/ui/_fsp.py b/piker/ui/_fsp.py
@@ -707,7 +707,7 @@ async def open_vlm_displays(
 
         last_val_sticky.update_from_data(-1, value)
 
-        _, vlm_curve = vlm_viz.update_graphics()
+        _, _, vlm_curve = vlm_viz.update_graphics()
 
         # size view to data once at outset
         vlm_chart.view._set_yrange(
-Original file line number
+Diff line change
@@ Expand Up / @@ -1061,7 +1061,7 @@ def default_view( @@
                 else:
                     log.warning(f'Unknown view state {vl} -> {vr}')
-                    return
+                    # return
                     # raise RuntimeError(f'Unknown view state {vl} -> {vr}')
             else:
@@ Expand Down @@