Actually yes, we need to handle empty in-view range..

pikers · Mar 10, 2023 · ca71e32 · ca71e32
1 parent 6b8ca8f
commit ca71e32
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/piker/ui/view_mode.py b/piker/ui/view_mode.py
@@ -668,18 +668,17 @@ def overlay_viewlists(
                                 f'yref@xref_pin: {yref}\n'
                             )
 
-                    # if we need to handle not-in-view cases?
-                    # mx_scalars = mx_viz.scalars_from_index(xref)
-                    # if mx_scalars is None:
-                    #     continue
-
+                    # XXX: we need to handle not-in-view cases?
+                    # still not sure why or when tf this happens..
+                    mx_scalars = mx_viz.scalars_from_index(xref)
+                    if mx_scalars is None:
+                        continue
                     (
                         i_start,
                         y_ref_major,
                         r_up_from_major_at_xref,
                         r_down_from_major_at_xref,
-                    ) = mx_viz.scalars_from_index(xref)
-                    # ) = mx_scalars
+                    ) = mx_scalars
 
                     if debug_print:
                         print(